Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Crash in bridge input pasted non-numeric and add v1link translation #11132

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

fix: Crash in bridge input pasted non-numeric and add v1link translation #11132

wants to merge 6 commits into from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Jan 13, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing the V1BridgeLink component to accept a customizable link text, improving localization support, and integrating new hooks for better functionality in the CanonicalBridge component.

Detailed summary

  • Updated package.json to include @pancakeswap/hooks.
  • Modified V1BridgeLink to accept a v1LinkText prop.
  • Passed translated text for the bridge link from the BridgePage.
  • Added localization entry for "V1 Bridge supports bridging to/from Aptos".
  • Implemented useLastUpdated hook in CanonicalBridge for input handling.
  • Enhanced input validation for the transfer input field.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 7:03am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 7:03am
blog ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 7:03am
bridge ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 7:03am
games ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 7:03am
gamification ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 7:03am
uikit ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 7:03am
ton ⬜️ Skipped (Inspect) Mar 18, 2025 7:03am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3494e9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@memoyil memoyil changed the title fix: Bridge input pasted non-numeric in mobile fix: Crash in bridge input pasted non-numeric in mobile Jan 13, 2025
@memoyil memoyil marked this pull request as draft January 13, 2025 14:53
@memoyil memoyil force-pushed the feature/fix_bridge_input_paste_non_numeric_in_mobile branch from 904aaae to 7a1ba6a Compare January 13, 2025 17:37
@memoyil memoyil marked this pull request as ready for review January 13, 2025 17:38
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 13, 2025
@vercel vercel bot temporarily deployed to Preview – ton January 13, 2025 17:43 Inactive
@vercel vercel bot temporarily deployed to Preview – ton January 13, 2025 17:48 Inactive
@memoyil memoyil changed the title fix: Crash in bridge input pasted non-numeric in mobile fix: Crash in bridge input pasted non-numeric in mobile and add v1link translation Jan 13, 2025
@memoyil memoyil added the Sentry label Jan 13, 2025
@memoyil memoyil changed the title fix: Crash in bridge input pasted non-numeric in mobile and add v1link translation fix: Crash in bridge input pasted non-numeric and add v1link translation Jan 13, 2025
@vercel vercel bot temporarily deployed to Preview – ton January 13, 2025 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview – ton January 14, 2025 08:10 Inactive
@socket-security Socket Security
Copy link

socket-security bot commented Jan 14, 2025 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@vercel vercel bot temporarily deployed to Preview – ton January 14, 2025 08:14 Inactive
@memoyil memoyil force-pushed the feature/fix_bridge_input_paste_non_numeric_in_mobile branch from 85f9998 to 89370e8 Compare January 14, 2025 08:15
@memoyil
Copy link
Collaborator Author

memoyil commented Jan 14, 2025

@SocketSecurity ignore-all

@memoyil memoyil force-pushed the feature/fix_bridge_input_paste_non_numeric_in_mobile branch from 89370e8 to 99dea64 Compare February 17, 2025 13:10
@memoyil memoyil force-pushed the feature/fix_bridge_input_paste_non_numeric_in_mobile branch from 99dea64 to 3494e9a Compare March 18, 2025 06:50
@vercel vercel bot temporarily deployed to Preview – ton March 18, 2025 06:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChefMomota ChefMomota Awaiting requested review from ChefMomota

@Chef-Yogi Chef-Yogi Awaiting requested review from Chef-Yogi Chef-Yogi is a code owner

@chefjackson chefjackson Awaiting requested review from chefjackson chefjackson is a code owner

@ChefJerry ChefJerry Awaiting requested review from ChefJerry ChefJerry is a code owner

@thechefpenguin thechefpenguin Awaiting requested review from thechefpenguin thechefpenguin is a code owner

@chef-eric chef-eric Awaiting requested review from chef-eric chef-eric is a code owner

@chef-ryan chef-ryan Awaiting requested review from chef-ryan chef-ryan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Sentry size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@memoyil